Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Java's version to 2.0.0 #22

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Upgrade Java's version to 2.0.0 #22

merged 1 commit into from
Jun 15, 2022

Conversation

supl
Copy link
Collaborator

@supl supl commented Jun 15, 2022

This PR revises the Java's module version to 2.0.0 since this version removes a gRPC service.

@supl supl added the enhancement New feature or request label Jun 15, 2022
@supl supl requested review from brfrn169 and feeblefakie June 15, 2022 04:47
@supl supl self-assigned this Jun 15, 2022
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

The reason for the major version upgrade is because of the removal of stats interface, right?

@supl
Copy link
Collaborator Author

supl commented Jun 15, 2022

LGTM! Thank you!

The reason for the major version upgrade is because of the removal of stats interface, right?

Yes. It is!

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit d9336b1 into main Jun 15, 2022
@brfrn169 brfrn169 deleted the 2.0.0 branch June 15, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants