Add a warning message for -s option
#51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supl
force-pushed
the
add-warning-message
branch
from
939d775 to
906a08c
Compare
supl
commented
Jul 22, 2024
src/main/resources/log4j2.properties
Outdated
Comment on lines
1
to
8
| # The root logger with appender name | ||
| rootLogger = INFO, STDOUT | ||
|
|
||
| # Assign STDOUT a valid appender & define its layout | ||
| appender.console.name = STDOUT | ||
| appender.console.type = Console | ||
| appender.console.layout.type = PatternLayout | ||
| appender.console.layout.pattern = %msg%n |
There was a problem hiding this comment.
we forgot to update the property file when we upgraded log4j to version 2.
6 tasks
kota2and3kan
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
LGTM! Thank you!
FYI: I was able to see the warning message in my local environment as follows!
$ java -jar build/libs/scalar-admin-2.2.0-all.jar -s localhost -c pause
Warning: --srv-service-url, -s will be deprecated in the future. We recommend using --addresses, -a instead.
feeblefakie
reviewed
Jul 23, 2024
| @@ -107,6 +111,9 @@ public Integer call() { | |||
| throw new IllegalArgumentException( | |||
| "It's required to specify only either [--srv-service-url, -s] or [--addresses, -a]."); | |||
| } else if (srvServiceUrl != null) { | |||
| logger.error( | |||
There was a problem hiding this comment.
Suggested change
| logger.error( | |
| logger.warn( |
Why do you use error?
Also, I don't think we need Warnings: header since it's done by the logger.
There was a problem hiding this comment.
Sorry, it was my typo. It should be warn.
(I remembered I used warn though, anyway.)
Also, I don't think we need Warnings: header since it's done by the logger.
Ah, I see. I did this because I configured the log4j2 output pattern to be just plaintext.
I made a change according to this comment at 27315b4
Please take a look 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a warning message when the users use the
-soption. This is advised in #50Related issues and/or PRs
#50
Changes made
Checklist