Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring td agent buffer #172

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Refactoring td agent buffer #172

merged 2 commits into from
Jul 29, 2020

Conversation

tei-k
Copy link
Contributor

@tei-k tei-k commented Jul 27, 2020 •
edited
Loading

Description

https://scalar-labs.atlassian.net/browse/DLT-6787

Done

  • Fix buffer path instead of ${hostname}/%Y/%m-%d/
[root@monitor-1 buffer]# ll /log
total 0
drwxr-xr-x. 3 td-agent td-agent 18 Jul 27 05:40 bastion-1
drwxr-xr-x. 2 td-agent td-agent  6 Jul 27 08:17 buffer
drwxr-xr-x. 3 td-agent td-agent 18 Jul 27 06:30 cassandra-1
drwxr-xr-x. 3 td-agent td-agent 18 Jul 27 06:30 cassandra-2
drwxr-xr-x. 3 td-agent td-agent 18 Jul 27 05:02 cassandra-3
drwxr-xr-x. 3 td-agent td-agent 18 Jul 27 04:53 monitor-1

2020-07-27 07:53:22 +0000 [warn]: #0 define <match fluent.**> to capture fluentd logs in top level is deprecated. Use <label @FLUENT_LOG> instead

@tei-k tei-k self-assigned this Jul 27, 2020
@tei-k tei-k changed the title [WIP] Refactoring td agent buffer Refactoring td agent buffer Jul 28, 2020
@tei-k tei-k requested review from feeblefakie and ymorimo July 28, 2020 00:44
ymorimo
ymorimo approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@ymorimo ymorimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

feeblefakie
feeblefakie approved these changes Jul 29, 2020
View reviewed changes
Copy link
Collaborator

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
I left 1 question to understand it properly.

provision/ansible/playbooks/templates/td-agent-confd/td-agent-monitor.conf.j2
@type relabel
@label @local
</match>
<label @FLUENT_LOG>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it related to the buffer thing ? or it is just nice to add thing ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to do with the buffer thing. I just corrected the writing of the deprecation. 🙈

@feeblefakie feeblefakie merged commit f969dab into master Jul 29, 2020
@feeblefakie feeblefakie deleted the refactoring-td-agent-buffer branch July 29, 2020 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymorimo ymorimo ymorimo approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

Assignees

@tei-k tei-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tei-k @ymorimo @feeblefakie