Update universal/scalardl module to use schema loader image for Cassandra #185
Conversation
| @@ -13,6 +16,7 @@ resource "null_resource" "scalardl_image" { | |||
|
|
|||
| triggers = { | |||
| scalar_tag = var.scalardl_image_tag | |||
| triggers = join(",", var.triggers) | |||
There was a problem hiding this comment.
Why add triggers here ? Do we need to rebuild the image locally due to changes in bastion or Cassandra?
| @@ -27,7 +31,6 @@ resource "null_resource" "scalardl_image_push" { | |||
|
|
|||
| triggers = { | |||
| docker_image = null_resource.scalardl_image[0].id | |||
| triggers = join(",", var.triggers) | |||
There was a problem hiding this comment.
Is it related to this PR?
Maybe this is necessary, because if the bastion is replaced, we need to upload again to bastion.
There was a problem hiding this comment.
I intended to modify the "triggers" tree but I'm bit confused with it. I'd like to discuss this later.
There was a problem hiding this comment.
Thanks! I understand that this is an improvement on the triggers. 👍
| @@ -148,7 +191,7 @@ resource "null_resource" "scalardl_schema" { | |||
|
|
|||
| provisioner "remote-exec" { | |||
| inline = [ | |||
| "docker run -e CASSANDRA_REPLICATION_FACTOR=${var.replication_factor} --rm ${local.scalar_image} dockerize -template create_schema.cql.tmpl:create_schema.cql -wait tcp://${local.scalar_cassandra_host}:9042 -timeout 30s cqlsh --cqlversion=3.4.4 ${local.scalar_cassandra_host} -u '${var.cassandra_username}' -p '${var.cassandra_password}' -f create_schema.cql" | |||
| "docker run -e CASSANDRA_HOST='${local.scalar_cassandra_host}' -e CASSANDRA_USERNAME='${var.cassandra_username}' -e CASSANDRA_PASSWORD='${var.cassandra_password}' -e CASSANDRA_REPLICATION_FACTOR=${var.replication_factor} --rm ${local.schema_loader_cassandra_image}" | |||
There was a problem hiding this comment.
Why use single quotes? for escaping?
I'm a little concerned when the password contains single quotes.
There was a problem hiding this comment.
It seems that single quotations are used because they are surrounded by double quotations. The problem is the same as before. I will check if it fails if the username or password contains any single quotation, and report it as a bug later.
There was a problem hiding this comment.
Thanks!
It's an existing problem, and I think it's fine to consider it separately.
https://scalar-labs.atlassian.net/browse/DLT-6879
This PR changes
universal/scalardlmodule to use scalardl-schama-loader-cassandra for the initial schema creation. The image is needed to be transferred to one of the scalardl hosts in the same way as thescalar-ledgerimage.The
cqlshandcreate_schema.cqlscript in scalar-ledger image is no longer used. (They are going to be removed in the next version of scalar-ledger.)