Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix location to region for k8s #186

Merged
merged 3 commits into from
Aug 18, 2020
Merged

fix location to region for k8s #186

merged 3 commits into from
Aug 18, 2020

Conversation

penpyt
Copy link
Contributor

@penpyt penpyt commented Aug 18, 2020

Goal

fix location to region

Reference

https://scalar-labs.atlassian.net/browse/DLT-7004

@penpyt penpyt self-assigned this Aug 18, 2020
@penpyt penpyt requested review from feeblefakie and tei-k August 18, 2020 02:06
tei-k
tei-k approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@tei-k tei-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

feeblefakie
feeblefakie approved these changes Aug 18, 2020
View reviewed changes
Copy link
Collaborator

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feeblefakie feeblefakie merged commit 86f96f8 into master Aug 18, 2020
@feeblefakie feeblefakie deleted the fix-location-region-for-k8s branch August 18, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feeblefakie feeblefakie feeblefakie approved these changes

@tei-k tei-k tei-k approved these changes

Assignees

@penpyt penpyt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@penpyt @feeblefakie @tei-k