-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add microservice transaction sample with Shared-cluster pattern with ScalarDB JDBC #64
base: main
Are you sure you want to change the base?
Add microservice transaction sample with Shared-cluster pattern with ScalarDB JDBC #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some minor suggestions. Other than that, LGTM. Thank you!🙇🏻♂️
...th-shared-cluster-with-jdbc/client/src/main/java/sample/client/command/RepaymentCommand.java
Outdated
Show resolved
Hide resolved
...n-sample-with-shared-cluster-with-jdbc/client/src/main/java/sample/client/command/Utils.java
Outdated
Show resolved
Hide resolved
...shared-cluster-with-jdbc/customer-service/src/main/java/sample/customer/CustomerService.java
Outdated
Show resolved
Hide resolved
...shared-cluster-with-jdbc/customer-service/src/main/java/sample/customer/CustomerService.java
Outdated
Show resolved
Hide resolved
...ple-with-shared-cluster-with-jdbc/order-service/src/main/java/sample/order/OrderService.java
Outdated
Show resolved
Hide resolved
...ple-with-shared-cluster-with-jdbc/order-service/src/main/java/sample/order/OrderService.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Josh Wong <joshua.wong@scalar-labs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
FYI: I was able to run this sample application by following the document in https://github.com/scalar-labs/docs-internal-scalardb/pull/185.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Description
This PR adds the microservice transaction sample with Shared-cluster pattern with ScalarDB JDBC.
Related issues and/or PRs
N/A
Changes made
Checklist
Additional notes (optional)
N/A