Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add microservice transaction sample with Shared-cluster pattern with ScalarDB JDBC #64

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Jul 20, 2024

Description

This PR adds the microservice transaction sample with Shared-cluster pattern with ScalarDB JDBC.

Related issues and/or PRs

N/A

Changes made

  • Added the microservice transaction sample with Shared-cluster pattern with ScalarDB JDBC.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

@brfrn169 brfrn169 self-assigned this Jul 20, 2024
@brfrn169 brfrn169 changed the title Add microservice transactions sample with Shared-cluster pattern with ScalarDB JDBC Add microservice transaction sample with Shared-cluster pattern with ScalarDB JDBC Jul 20, 2024
Copy link
Member

@josh-wong josh-wong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some minor suggestions. Other than that, LGTM. Thank you!🙇🏻‍♂️

Co-authored-by: Josh Wong <joshua.wong@scalar-labs.com>
Copy link
Contributor

@kota2and3kan kota2and3kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

FYI: I was able to run this sample application by following the document in https://github.com/scalar-labs/docs-internal-scalardb/pull/185.

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants