-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support encrypted columns in Schema Loader #1975
Conversation
@@ -162,7 +163,8 @@ public boolean equals(Object o) { | |||
&& Objects.equals(partitionKeyNames, metadata.partitionKeyNames) | |||
&& Objects.equals(clusteringKeyNames, metadata.clusteringKeyNames) | |||
&& Objects.equals(clusteringOrders, metadata.clusteringOrders) | |||
&& Objects.equals(secondaryIndexNames, metadata.secondaryIndexNames); | |||
&& Objects.equals(secondaryIndexNames, metadata.secondaryIndexNames) | |||
&& Objects.equals(encryptedColumnNames, metadata.encryptedColumnNames); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to add encryptedColumnNames
to equals()
and hashCode()
in the previous PR...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Description
This PR adds support for encrypted columns to Schema Loader. With this change, users can specify the
ENCRYPTED
flag in the column definition as follows:In the above example, the
ENCRYPTED
flag is specified for thec2
andc5
columns:Related issues and/or PRs
Changes made
Checklist
Additional notes (optional)
N/A
Release notes
Same as #1907