Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support encrypted columns in Schema Loader #1975

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Jun 21, 2024

Description

This PR adds support for encrypted columns to Schema Loader. With this change, users can specify the ENCRYPTED flag in the column definition as follows:

{
  "sample_db.sample_table": {
    "partition-key": [
      "c1"
    ],
    "clustering-key": [
      "c4 ASC",
      "c6 DESC"
    ],
    "columns": {
      "c1": "INT",
      "c2": "TEXT ENCRYPTED",
      "c3": "BLOB",
      "c4": "INT",
      "c5": "BOOLEAN ENCRYPTED",
      "c6": "INT"
    }
  }
}

In the above example, the ENCRYPTED flag is specified for the c2 and c5 columns:

Related issues and/or PRs

Changes made

  • Added support for encrypted columns to Schema Loader.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

Same as #1907

@brfrn169 brfrn169 added the enhancement New feature or request label Jun 21, 2024
@brfrn169 brfrn169 self-assigned this Jun 21, 2024
@@ -162,7 +163,8 @@ public boolean equals(Object o) {
&& Objects.equals(partitionKeyNames, metadata.partitionKeyNames)
&& Objects.equals(clusteringKeyNames, metadata.clusteringKeyNames)
&& Objects.equals(clusteringOrders, metadata.clusteringOrders)
&& Objects.equals(secondaryIndexNames, metadata.secondaryIndexNames);
&& Objects.equals(secondaryIndexNames, metadata.secondaryIndexNames)
&& Objects.equals(encryptedColumnNames, metadata.encryptedColumnNames);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to add encryptedColumnNames to equals() and hashCode() in the previous PR...

Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit 2c8f025 into master Jun 25, 2024
47 checks passed
@brfrn169 brfrn169 deleted the support-encrypted-columns-in-schema-loader branch June 25, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants