Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add integration test for MariaDB 11.4 and Oracle 19 #2061

Merged
merged 5 commits into from
Jul 26, 2024
Merged

[CI] Add integration test for MariaDB 11.4 and Oracle 19 #2061

merged 5 commits into from
Jul 26, 2024

Conversation

Torch3333
Copy link
Contributor

@Torch3333 Torch3333 commented Jul 11, 2024 •
edited
Loading

Description

This adds integration tests for MariaDB 11.4 and Oracle 19 in the CI.

Related issues and/or PRs

N/A

Changes made

  • Add integration test for MariaDB 11.4 and Oracle 19 in the CI

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

While there are completely free Oracle DB for commercial use for versions 18, 21 and 23, no free version for Oracle 19 is available. However, we can use it as long as it is for testing purposes.

Release notes

Supports MariaDB 11.4 and Oracle 19.

@Torch3333 Torch3333 self-assigned this Jul 11, 2024
@Torch3333 Torch3333 force-pushed the ci_oracle_19_maria_db_11 branch 2 times, most recently from 2cc9c88 to 6c71427 Compare July 16, 2024 05:13
@Torch3333 Torch3333 force-pushed the ci_oracle_19_maria_db_11 branch from 6c71427 to 753d250 Compare July 16, 2024 06:13
@Torch3333 Torch3333 marked this pull request as ready for review July 17, 2024 00:37
@Torch3333 Torch3333 added the enhancement New feature or request label Jul 17, 2024
brfrn169
brfrn169 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment. Other than that, LGTM! Thank you!

.github/workflows/ci.yaml
@@ -952,6 +952,70 @@ jobs:
name: oracle_18_integration_test_reports_${{ matrix.mode.label }}
path: core/build/reports/tests/integrationTestJdbc

integration-test-for-jdbc-oracle-19:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we've added this, we can remove integration-test-for-jdbc-oracle-18.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it's revised in d4c15a0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we keep Oracle 18 on the CI for already released versions? Do you think about keeping Oracle 18 on the Supported database documentation or replacing it with Oracle 19 ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can delete Oracle 18 from the supported database documentation. @feeblefakie What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brfrn169 I think so. The updated version is in my PR, so let me handle this.

feeblefakie
feeblefakie approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

.github/workflows/ci.yaml
@@ -952,6 +952,70 @@ jobs:
name: oracle_18_integration_test_reports_${{ matrix.mode.label }}
path: core/build/reports/tests/integrationTestJdbc

integration-test-for-jdbc-oracle-19:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brfrn169 I think so. The updated version is in my PR, so let me handle this.

komamitsu
komamitsu approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@brfrn169 brfrn169 merged commit 5d92267 into master Jul 26, 2024
49 checks passed
@brfrn169 brfrn169 deleted the ci_oracle_19_maria_db_11 branch July 26, 2024 11:58
feeblefakie pushed a commit that referenced this pull request Jul 26, 2024
@Torch3333
[CI] Add integration test for MariaDB 11.4 and Oracle 19 (#2061)
322b474
@feeblefakie feeblefakie mentioned this pull request Jul 26, 2024
Merged
feeblefakie pushed a commit that referenced this pull request Jul 26, 2024
@Torch3333
[CI] Add integration test for MariaDB 11.4 and Oracle 19 (#2061)
24c513b
This was referenced Jul 26, 2024
Merged
Closed
Closed
Closed
Closed
This was referenced Jul 29, 2024
Merged
Merged
Merged
@Torch3333 Torch3333 mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brfrn169 brfrn169 brfrn169 approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

@komamitsu komamitsu komamitsu approved these changes

Assignees

@Torch3333 Torch3333

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Torch3333 @komamitsu @brfrn169 @feeblefakie