Backport to branch(3) : Fix a corner case issue that causes inconsistent Coordinator states when lazy recovery happens before group commit #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen lazy recovery happens before group commit (#2135)
|
@komamitsu Could you please take a look at the CI failures when you have time? |
|
@brfrn169 Oh, thanks. I forgot that empty PRs are created instead of issues. |
Ah, no. This was a CI failure not cherry-pick failure... |
ScalarDB 3 doesn't have `coordinator.state.tx_child_ids` column when the group commit feature is disabled. Skip this test in this case.
|
@brfrn169 The cause of the test failures was ScalarDB v3 doesn't create Thanks for letting me know that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2135