For IBM Db2, change the data type for BLOB column to support storing up to 2GB #3000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torch3333
force-pushed
the
db2_change_blob_type_mapping
branch
2 times, most recently
from
f2b485b to
8ef0b7b
Compare
…" to "BLOB(2G)" [skip ci]
Torch3333
force-pushed
the
db2_change_blob_type_mapping
branch
from
51f8972 to
683f011
Compare
Torch3333
changed the title
Torch3333
changed the title
Torch3333
requested review from
a team,
brfrn169,
feeblefakie and
komamitsu
and removed request for
a team
komamitsu
reviewed
Sep 5, 2025
core/src/main/java/com/scalar/db/common/checker/OperationChecker.java
Outdated
Show resolved
Hide resolved
brfrn169
changed the title
…e_mapping # Conflicts: # core/src/integration-test/java/com/scalar/db/storage/jdbc/ConsensusCommitAdminIntegrationTestWithJdbcDatabase.java # core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcAdminCaseSensitivityIntegrationTest.java # core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcAdminIntegrationTest.java # core/src/integration-test/java/com/scalar/db/storage/jdbc/SingleCrudOperationTransactionAdminIntegrationTestWithJdbcDatabase.java # core/src/integration-test/java/com/scalar/db/transaction/jdbc/JdbcTransactionAdminIntegrationTest.java # core/src/main/java/com/scalar/db/common/CoreError.java
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively increases the BLOB size limit for Db2 by changing the data type to BLOB(2G). The associated limitations are handled well with new checks and error messages, and the integration tests are updated accordingly. I've identified a few areas in the unit tests where the changes to accommodate Db2's new limitations have unintentionally reduced test coverage for other databases. My review includes suggestions to conditionally adapt the tests based on the RDB engine to maintain this coverage.
brfrn169
reviewed
Sep 19, 2025
core/src/main/java/com/scalar/db/common/checker/OperationChecker.java
Outdated
Show resolved
Hide resolved
brfrn169
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR changes the IBM Db2 BLOB column data type mapping from VARBINARY(32672) to BLOB(2G) to support storing up to 2GB of data. Due to limitations of the Db2 BLOB data type, BLOB columns can no longer be used as primary keys, clustering keys, secondary indexes, or in ordering operations for cross-partition scans.
- Changes Db2 BLOB column mapping to support 2GB storage capacity
- Implements validation to prevent BLOB columns from being used as keys or indexes in Db2
- Updates integration tests to conditionally skip BLOB-related tests for Db2
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| RdbEngineDb2.java | Changes BLOB data type mapping and adds validation for unsupported BLOB operations |
| JdbcOperationChecker.java | New operation checker that validates cross-partition scan ordering on BLOB columns |
| CoreError.java | Adds new error messages for Db2 BLOB column restrictions |
| JdbcDatabase.java | Updates to use the new JdbcOperationChecker |
| OperationChecker.java | Makes checkOrderingsForScanAll method protected for extension |
| Integration test files | Updates test methods to conditionally skip BLOB-related operations for Db2 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
core/src/test/java/com/scalar/db/storage/jdbc/JdbcAdminTest.java
Outdated
Show resolved
Hide resolved
komamitsu
reviewed
Sep 22, 2025
core/src/test/java/com/scalar/db/storage/jdbc/JdbcOperationCheckerTest.java
Outdated
Show resolved
Hide resolved
…e_mapping # Conflicts: # core/src/main/java/com/scalar/db/common/CoreError.java
Torch3333
added a commit
that referenced
this pull request
Sep 24, 2025
…up to 2GB (#3000) # Conflicts: # core/src/test/java/com/scalar/db/storage/jdbc/JdbcAdminTestBase.java
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the default mapping for Db2 BLOB column to a data type that allows storing up to 2GB. This changes addresses concerns that the original data type only allowed to store up 32KB which was deemed too restrictive.
The new Db2 data type used is named
BLOBand its maximum capacity is 2GB for Db2 LUW, which also coincides with the maximum capacity that the backing objectbyte[]of BlobColumn object can hold.Because of limitations of the Db2
BLOBdata type, ScalarDB BLOB column can no longer be used as :Related issues and/or PRs
Changes made
VARBINARY(32672)toBLOB(2G)Checklist
Additional notes (optional)
Release notes
When using Db2, the default data type used for ScalarDB BLOB column from Db2 is changed from
VARBINARY(32672)toBLOB(2G)to allow storing data up to 2GB. This brings new limitations that a BLOB column can no longer be used as partition key, clustering key, secondary index or as an ordering column in a cross-partitions scan, .i.e. ScanAll, operation.