Add guide for custom docker images #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yixu34
commented
May 16, 2023
yixu34
commented
phil-scale
reviewed
May 16, 2023
docs/guides/custom_docker_images.md
Outdated
|
|
||
| from pydantic import BaseModel | ||
|
|
||
| import my_inference_fn # This is your inference function, defined elsewhere within your Python codebase. |
There was a problem hiding this comment.
This wouldn't work with doc-testing integration tests
There was a problem hiding this comment.
Hmm ok I'll just define it inline here then.
phil-scale
reviewed
May 16, 2023
docs/guides/custom_docker_images.md
Outdated
Comment on lines
93
to
111
| ``` | ||
|
|
||
| Creating the Model Endpoint: | ||
| ```python3 | ||
| client.create_model_endpoint( | ||
| endpoint_name=f"endpoint-{model_bundle_name}", | ||
| model_bundle=model_bundle_name, | ||
| endpoint_type="async", | ||
| min_workers=0, | ||
| max_workers=1, | ||
| per_worker=1, | ||
| memory="30Gi", | ||
| storage="40Gi", | ||
| cpus=4, | ||
| gpus=1, | ||
| gpu_type="nvidia-ampere-a10", | ||
| update_if_exists=True, | ||
| ) | ||
| ``` |
There was a problem hiding this comment.
Since integration tests run each code snippet separately, it would only pass tests if you unified these two blocks - maybe you could just make Creating the Model Endpoint: a comment
phil-scale
approved these changes
May 17, 2023
tests/test_docs.py
Outdated
| @@ -45,7 +45,13 @@ def extract_code_chunks(path: Path, text: str, offset: int): | |||
| code = m_code.group(2) | |||
| end_line = start_line + code.count("\n") + 1 | |||
| source = "\n" * start_line + code | |||
| if "test='skip'" in prefix: | |||
| if "test='skip'" in source: | |||
There was a problem hiding this comment.
Not necessary for this PR but I think it would be good to find a solution that doesn't show this comment in the documentation
There was a problem hiding this comment.
Hm ok tried a couple of things but didn't seem to work - I think test_docs can't rewrite the source?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.