Skip to content

Fix launch CLI bug in launch endpoints delete causing the command to fail with a TypeError #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2024
Merged

Fix launch CLI bug in launch endpoints delete causing the command to fail with a TypeError #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1706a6
modify launch.cli.delete_endpoint to pass endpoint_name directly into…
anant-marur May 23, 2024
f46eb35
remove unused ModelEndpoint import
anant-marur May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions launch/cli/endpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
from launch.cli.client import init_client
from launch.cli.console import pretty_print, spinner
from launch.hooks import PostInferenceHooks
from launch.model_endpoint import ModelEndpoint


@click.group("endpoints")
Expand Down Expand Up @@ -104,8 +103,7 @@ def delete_endpoint(ctx: click.Context, endpoint_name: str):
client = init_client(ctx)

with spinner(f"Deleting model endpoint '{endpoint_name}'"):
endpoint = ModelEndpoint(name=endpoint_name)
res = client.delete_model_endpoint(endpoint)
res = client.delete_model_endpoint(endpoint_name)

pretty_print(res)

Expand Down