Skip to content

Support handling streaming in SGP #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2024
Merged

Support handling streaming in SGP #169

merged 1 commit into from
Jul 15, 2024

Conversation

khshah6
Copy link
Contributor

@khshah6 khshah6 commented Jul 12, 2024

No description provided.

seanshi-scale
seanshi-scale approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@seanshi-scale seanshi-scale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean we've already implemented returning streaming from this client and we just need to expose the class for others to import?

@khshah6
Copy link
Contributor Author

khshah6 commented Jul 12, 2024

does this mean we've already implemented returning streaming from this client and we just need to expose the class for others to import?

Yeah it seems like this is working for launch streaming models, still testing it though

@khshah6 khshah6 merged commit fa14718 into scaleapi:master Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanshi-scale seanshi-scale seanshi-scale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khshah6 @seanshi-scale