create_model_bundle metadata param #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeakymouse
commented
May 13, 2023
Comment on lines
-336
to
-337
| bundle_metadata["load_predict_fn"] = inspect.getsource(load_predict_fn) # type: ignore | ||
| bundle_metadata["load_model_fn"] = inspect.getsource(load_model_fn) # type: ignore |
There was a problem hiding this comment.
@phil-scale Is this ok to remove? Didn't look like bundle_metadata was being used anywhere
phil-scale
reviewed
May 15, 2023
|
Yep, I think I've done that? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the protocol for testing changes? Is there an easier way than re-installing from local repository and writing a test script that will create actual bundles on prod? 😮
For https://app.shortcut.com/scaleai/story/756558/expose-git-commit-hash-for-launch-deployments