Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-interactive installation during docker build #533

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

yunfeng-scale
Copy link
Contributor

@yunfeng-scale yunfeng-scale commented Jun 3, 2024

Pull Request Summary

seeing tzdata installation hanging due to region selection: https://app.datadoghq.com/logs?query=kube_job%3Akaniko-4079a805%20&agg_m=count&agg_m_source=base&agg_t=count&cols=host%2Cservice&fromUser=true&messageDisplay=inline&refresh_mode=sliding&storage=hot&stream_sort=time%2Cdesc&viz=stream&from_ts=1717453458877&to_ts=1717457058877&live=true

add non-interactive installation as referred in https://askubuntu.com/questions/909277/avoiding-user-interaction-with-tzdata-when-installing-certbot-in-a-docker-contai

this appears to happen building images using newer pytorch base images like 2.1.0-cuda12.1-cudnn8-runtime

Test Plan and Usage Guide

How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.

@yunfeng-scale yunfeng-scale changed the title Non-interactive installation during docker build MLI-2431 Non-interactive installation during docker build Jun 3, 2024
@yunfeng-scale yunfeng-scale requested a review from a team June 3, 2024 23:31
@yunfeng-scale yunfeng-scale changed the title MLI-2431 Non-interactive installation during docker build Non-interactive installation during docker build Jun 3, 2024
Copy link
Contributor

@ian-scale ian-scale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edgan8
Copy link
Collaborator

edgan8 commented Jun 3, 2024

Did we test that this works? Worried that it might not fix our issue.

@yunfeng-scale
Copy link
Contributor Author

Did we test that this works? Worried that it might not fix our issue.

tested with user artifact and it works

@yunfeng-scale yunfeng-scale merged commit bd192cb into main Jun 4, 2024
5 checks passed
@yunfeng-scale yunfeng-scale deleted the yunfeng-non-interactive branch June 4, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants