Skip to content

Conversation

@rodsca
Copy link
Contributor

@rodsca rodsca commented Feb 22, 2023

Pull Request Summary

Description

Please include a summary of the changes. Please also include the relevant context and motivation. List any dependencies and assumptions that are required for this change.

Implemented task tags endpoints to set, add, and delete tags from a given task.

How did you test your code?

Which of the following have you done to test your changes? Please describe the tests that you ran to verify your changes.

  • Created new unit tests in tests/ for the newly implemented methods
  • Updated existing unit tests in tests/ to cover changes made to existing methods

Checklist

Please make sure all items in this checklist have been fulfilled before sending your PR out for review!

  • I have commented my code in details, particularly in hard-to-understand areas
  • I have updated Readme.rst document with examples for newly implemented public methods
  • I have reviewed Deployment and Publishing Guide for Python SDK document
  • I incremented the SDK version in _version.py (unless this PR only updates the documentation).
  • In order to release a new version, a "Release Summary" needs to be prepared and published after the merge

Copy link
Contributor

@jonathanfeng-scale jonathanfeng-scale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rodsca rodsca requested review from fatihkurtoglu and removed request for fatihkurtoglu and kevin-xu-scale February 22, 2023 21:50
Copy link
Contributor

@fatihkurtoglu fatihkurtoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for adding tags endpoints! Just left nit comments for readme formatting.

rodsca and others added 10 commits February 23, 2023 10:37
Co-authored-by: Fatih Kurtoglu <fatih.kurtoglu@scale.com>
Co-authored-by: Fatih Kurtoglu <fatih.kurtoglu@scale.com>
Co-authored-by: Fatih Kurtoglu <fatih.kurtoglu@scale.com>
Co-authored-by: Fatih Kurtoglu <fatih.kurtoglu@scale.com>
Co-authored-by: Fatih Kurtoglu <fatih.kurtoglu@scale.com>
Co-authored-by: Fatih Kurtoglu <fatih.kurtoglu@scale.com>
Co-authored-by: Fatih Kurtoglu <fatih.kurtoglu@scale.com>
Co-authored-by: Fatih Kurtoglu <fatih.kurtoglu@scale.com>
Co-authored-by: Fatih Kurtoglu <fatih.kurtoglu@scale.com>
Co-authored-by: Fatih Kurtoglu <fatih.kurtoglu@scale.com>
@jonathanfeng-scale
Copy link
Contributor

@fatihkurtoglu apparently we have to use Opal now to request for write access to this repo 😢

@rodsca rodsca merged commit 4105182 into master Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants