bug fix added missing dependency rxjs for @scalecube/api #257
Conversation
There was a problem hiding this comment.
About placing things in devDependencies or dependencies, as far as I know a good test to determine this is to check if packageB is used in some of the d.ts files of packageA. If yes, means that we'd better place packageB in the dependencies of packageA rather than devDependencies.
Based on that, in a few packages we should move @scalecube/api to dependencies and in some cases @scalecube/utils is not placed correctly also.
packages/utils/package.json
Outdated
| @@ -21,7 +21,7 @@ | |||
| }, | |||
| "author": "Scalecube (https://github.com/scalecube/scalecube-js)", | |||
| "devDependencies": { | |||
| "@scalecube/api": "^0.2.9", | |||
| "@scalecube/api": "^0.2.10", | |||
There was a problem hiding this comment.
@scalecube/api should be in dependencies for this package too
packages/routers/package.json
Outdated
| @@ -20,7 +20,7 @@ | |||
| }, | |||
| "author": "Scalecube (https://github.com/scalecube/scalecube-js)", | |||
| "devDependencies": { | |||
| "@scalecube/api": "^0.2.9", | |||
| "@scalecube/api": "^0.2.10", | |||
There was a problem hiding this comment.
@scalecube/api should be in dependencies for this package too
| @@ -23,8 +23,8 @@ | |||
| "author": "Scalecube (https://github.com/scalecube/scalecube-js)", | |||
| "devDependencies": { | |||
| "@babel/core": "^7.4.5", | |||
| "@scalecube/api": "^0.2.9", | |||
| "@scalecube/cluster-browser": "^0.2.9", | |||
| "@scalecube/api": "^0.2.10", | |||
There was a problem hiding this comment.
@scalecube/api should be in dependencies for this package too
| @@ -20,7 +20,7 @@ | |||
| }, | |||
| "author": "Scalecube (https://github.com/scalecube/scalecube-js)", | |||
| "devDependencies": { | |||
| "@scalecube/api": "^0.2.9", | |||
| "@scalecube/api": "^0.2.10", | |||
There was a problem hiding this comment.
@scalecube/api should be in dependencies for this package too
| @@ -20,7 +20,7 @@ | |||
| }, | |||
| "author": "Scalecube (https://github.com/scalecube/scalecube-js)", | |||
| "devDependencies": { | |||
| "@scalecube/api": "^0.2.9", | |||
| "@scalecube/api": "^0.2.10", | |||
There was a problem hiding this comment.
@scalecube/api should be in dependencies for this package too
packages/cluster-nodejs/package.json
Outdated
| @@ -20,7 +20,7 @@ | |||
| }, | |||
| "author": "Scalecube (https://github.com/scalecube/scalecube-js)", | |||
| "devDependencies": { | |||
| "@scalecube/api": "^0.2.9", | |||
| "@scalecube/api": "^0.2.10", | |||
There was a problem hiding this comment.
@scalecube/api should be in dependencies for this package too
# Conflicts: # yarn.lock
No description provided.