Refactor core for a more streamlined API for aggregators/controllers #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 23, 2022 13:59
|
It's a bit confusing that we have /network and common/net, I would name "net" to "grpc" and remove "web" inside net. Inside "grpc" I would also add a folder "proto" and put everything related to that in there. |
|
any reason why reducer don't have it's own folder? Combiner, Clients etc have it... |
|
I think I would move up (towards root) everything in fedn/fedn so that one would have "cli" on the same level as "network" etc. This is to avoid the ugly full paths such as fedn/fedn/fedn/network. |
No particular reason. |
…/fedn into feature/refactor
Wrede
reviewed
May 19, 2023
…/fedn into feature/refactor
…to feature/refactor
Wrede
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a major refactor of the core library, with the goals to provide: