Feature/SK-852 | Add numpy raw binary helper #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahellander
approved these changes
May 17, 2024
| @@ -0,0 +1,16 @@ | |||
| from fedn.utils.helpers.plugins.numpyhelper import Helper | |||
There was a problem hiding this comment.
Would it improve readability to do:
from fedn.utils.helpers.plugins.numpyhelper import Helper as NumpyHelper
..
class Helper(NumpyHelper)
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default numpyhelper is based on numpy compressed file format (npz). This PR introduces a new helper that enables raw binary file format (.bin) which will be read using either numpy.frombuffer or numpy.fromfile instead of numpy.load.
The helper is called "binaryhelper".