Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/SK-866 | Inference TaskType workflow #614

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Feature/SK-866 | Inference TaskType workflow #614

merged 5 commits into from
Jun 11, 2024

Conversation

Wrede
Copy link
Member

@Wrede Wrede commented May 24, 2024

introduces a new TaskType and workflow for inference on the server side.
Currently infernce will work very similar to validation except the number of rounds will only be 1.

It's up to the client side to respond to the TaskStream when statusType is of type "INFERENCE".

This PR does not introduce any client side inference actions.

Copy link
Member

@ahellander ahellander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in principle. See minor comment.

I have not tested though.

fedn/network/combiner/aggregators/aggregatorbase.py Outdated Show resolved Hide resolved
@Wrede Wrede requested a review from ahellander June 10, 2024 16:46
@Wrede Wrede dismissed ahellander’s stale review June 11, 2024 09:32

this has been adressed by logging the trace of the error

@Wrede Wrede merged commit b7ac10b into master Jun 11, 2024
15 checks passed
@Wrede Wrede deleted the feature/SK-866 branch June 11, 2024 09:33
@Wrede Wrede added the feature New feature or request label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants