Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/SK-811 | Example using Differential Privacy #698

Merged
merged 13 commits into from
Sep 12, 2024
Merged

Conversation

mattiasakesson
Copy link
Member

Description

@github-actions github-actions bot added minor feature New feature or request labels Sep 10, 2024
Copy link
Member

@ahellander ahellander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

See a few minor comments.

@@ -0,0 +1,56 @@
FEDn Project: Federated Differential Privacy MNIST (Opacus + PyTorch)
-----------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the dotted line has to span all the text to work.


MAX_GRAD_NORM = 1.2
FINAL_EPSILON = 8.0
ROUNDS = 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are global rounds, right? Maybe rename to GLOBAL_ROUNDS for clarity?

@mattiasakesson mattiasakesson changed the title Feature/sk 811 Feature/SK-811 Sep 12, 2024
@mattiasakesson mattiasakesson changed the title Feature/SK-811 Feature/SK.811 | Differential Privacy Sep 12, 2024
@mattiasakesson mattiasakesson changed the title Feature/SK.811 | Differential Privacy Feature/SK-811 | Differential Privacy Sep 12, 2024
@Wrede Wrede changed the title Feature/SK-811 | Differential Privacy Feature/SK-811 | Example using Differential Privacy Sep 12, 2024
@Wrede Wrede merged commit ed5ae94 into master Sep 12, 2024
19 checks passed
@Wrede Wrede deleted the feature/SK-811 branch September 12, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants