Skip to content

Conversation

Mia-Cross
Copy link
Contributor

@Mia-Cross Mia-Cross commented Oct 7, 2025

This PR makes a couple of changes in the output of the scw instance server get command:

  • remove the EnableIPv6 field as it is deprecated and its value is always false, even if the server has IPv6.
  • remove the PublicIP.Xxx fields as they are duplicated in the 'Public IPs' section below.
  • remove the IPv6 section as it is always empty, even if the server has IPv6, and that the actual IPv6 addresses can be found either in the 'Public IPs' or in the 'Private IPs' section.

@Mia-Cross Mia-Cross self-assigned this Oct 7, 2025
@Mia-Cross Mia-Cross added enhancement instance Instance issues, bugs and feature requests ux labels Oct 7, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.26%. Comparing base (5bf53e0) to head (2eda66e).
⚠️ Report is 835 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (2eda66e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (2eda66e)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5037       +/-   ##
===========================================
- Coverage   75.45%   56.26%   -19.20%     
===========================================
  Files         202      308      +106     
  Lines       44323    78080    +33757     
===========================================
+ Hits        33444    43930    +10486     
- Misses       9653    32743    +23090     
- Partials     1226     1407      +181     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mia-Cross Mia-Cross marked this pull request as ready for review October 7, 2025 15:37
@Mia-Cross Mia-Cross requested a review from a team as a code owner October 7, 2025 15:37
@remyleone remyleone added this pull request to the merge queue Oct 8, 2025
Merged via the queue into scaleway:master with commit e48ece1 Oct 8, 2025
20 of 21 checks passed
@Mia-Cross Mia-Cross deleted the instance_remove_ipv6_fields branch October 8, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement instance Instance issues, bugs and feature requests ux

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants