Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text input and date input to be fixed #3944

Merged
merged 5 commits into from
Jul 12, 2024
Merged

fix: text input and date input to be fixed #3944

merged 5 commits into from
Jul 12, 2024

Conversation

matthprost
Copy link
Collaborator

@matthprost matthprost commented Jul 2, 2024

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Fix <TextInputV2 /> prop onChange will now take function with event.

// Before
onChange={value => value}

// After
onChangeValue={value => value}
onChange={event => event.target.value}

This will also fix <DateInput /> issues such as editing the input value.

@matthprost matthprost added the bug Something isn't working label Jul 2, 2024
@matthprost matthprost self-assigned this Jul 2, 2024
Copy link

changeset-bot bot commented Jul 2, 2024

🦋 Changeset detected

Latest commit: 4f94762

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/form Patch
@ultraviolet/ui Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@scaleway-bot scaleway-bot temporarily deployed to fix-date-input-storybook July 2, 2024 16:48 Destroyed
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.22%. Comparing base (1d813c7) to head (4f94762).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3944   +/-   ##
=======================================
  Coverage   94.21%   94.22%           
=======================================
  Files         192      192           
  Lines        6380     6386    +6     
  Branches     2918     2918           
=======================================
+ Hits         6011     6017    +6     
  Misses        369      369           
Files Coverage Δ
...ges/form/src/components/TextInputFieldV2/index.tsx 91.66% <100.00%> (+0.36%) ⬆️
packages/ui/src/components/DateInput/index.tsx 100.00% <ø> (ø)
packages/ui/src/components/SearchInput/index.tsx 95.41% <100.00%> (+0.04%) ⬆️
...src/components/SelectInputV2/SearchBarDropdown.tsx 98.64% <100.00%> (ø)
packages/ui/src/components/TextInputV2/index.tsx 89.25% <100.00%> (+0.46%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d813c7...4f94762. Read the comment docs.

@matthprost matthprost changed the title Fix/date input fix: text input and date input to be fixed Jul 3, 2024
@scaleway-bot scaleway-bot temporarily deployed to fix-date-input-storybook July 3, 2024 08:29 Destroyed
@matthprost matthprost merged commit d571c5e into main Jul 12, 2024
11 checks passed
@matthprost matthprost deleted the fix/date-input branch July 12, 2024 08:40
@scaleway-bot scaleway-bot mentioned this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants