Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug fixes on selectinputV2 #4248

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix: bug fixes on selectinputV2 #4248

merged 2 commits into from
Sep 19, 2024

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Bug

Summarise concisely:

The following changes were made:

  1. No empty group name (container hidden)
  2. Dropdown positioning (resize with select bar)
  3. LoadMore appear at the end of the dropdown (not at the end of every group)
  4. Truncation in dropdown and select bar (ellipsis)
  5. Various style enhancement (group name color, states success, neutral, error, disabled, read-only when hover/focus/active)

Relevant logs and/or screenshots

Page Before After
Truncation Capture d’écran 2024-09-16 à 16 58 08 Capture d’écran 2024-09-16 à 16 57 14

@lisalupi lisalupi added the bug Something isn't working label Sep 16, 2024
@lisalupi lisalupi requested review from matthprost and a team September 16, 2024 15:31
@lisalupi lisalupi self-assigned this Sep 16, 2024
@lisalupi lisalupi requested review from JulienSaguez and removed request for a team September 16, 2024 15:31
Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: 7a050f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 86.98%. Comparing base (979f5f3) to head (7a050f1).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...kages/ui/src/components/SelectInputV2/Dropdown.tsx 36.36% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4248      +/-   ##
==========================================
- Coverage   86.99%   86.98%   -0.02%     
==========================================
  Files         315      315              
  Lines       11354    11376      +22     
  Branches     3069     3077       +8     
==========================================
+ Hits         9877     9895      +18     
- Misses       1477     1481       +4     
Files with missing lines Coverage Δ
...ui/src/components/SelectInputV2/DropdownOption.tsx 40.74% <100.00%> (+4.74%) ⬆️
...ages/ui/src/components/SelectInputV2/SelectBar.tsx 62.87% <100.00%> (+2.71%) ⬆️
...kages/ui/src/components/SelectInputV2/Dropdown.tsx 41.60% <36.36%> (+0.88%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 979f5f3...7a050f1. Read the comment docs.

@lisalupi lisalupi requested review from a team and johnrazeur and removed request for JulienSaguez and a team September 17, 2024 08:03
@lisalupi lisalupi merged commit 3c11e91 into main Sep 19, 2024
10 of 11 checks passed
@lisalupi lisalupi deleted the fix/selectinput branch September 19, 2024 07:54
@scaleway-bot scaleway-bot mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants