Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TextArea): add new props for allowing submit on enter pressed #4285

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

Add props onKeyDown and submitOnEnter on <TextAreaField />

@matthprost matthprost added the enhancement New feature or request label Sep 27, 2024
@matthprost matthprost requested review from ValentinRLL and a team September 27, 2024 13:29
@matthprost matthprost self-assigned this Sep 27, 2024
@matthprost matthprost requested review from vincentaudebert and alexandre-combemorel and removed request for a team September 27, 2024 13:29
Copy link

changeset-bot bot commented Sep 27, 2024

🦋 Changeset detected

Latest commit: d20092a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Minor
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthprost matthprost changed the title fix(TextAre): add new props for allowing submit on enter pressed fix(TextArea): add new props for allowing submit on enter pressed Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@a1f103b). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4285   +/-   ##
=======================================
  Coverage        ?   87.01%           
=======================================
  Files           ?      315           
  Lines           ?    11455           
  Branches        ?     3107           
=======================================
  Hits            ?     9967           
  Misses          ?     1488           
  Partials        ?        0           
Files with missing lines Coverage Δ
.../components/TextAreaField/__tests__/index.test.tsx 100.00% <100.00%> (ø)
...ckages/form/src/components/TextAreaField/index.tsx 91.66% <100.00%> (ø)
packages/ui/src/components/TextArea/index.tsx 91.46% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1f103b...d20092a. Read the comment docs.

@matthprost matthprost merged commit 820c5d4 into main Sep 27, 2024
21 checks passed
@matthprost matthprost deleted the fix/text-area-submit branch September 27, 2024 15:23
@scaleway-bot scaleway-bot mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants