Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TextArea): make label or aria label required #4312

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Fix <TextArea /> to have either label or aria-label as required prop

@matthprost matthprost added the bug Something isn't working label Oct 4, 2024
@matthprost matthprost requested review from DorianMaliszewski and a team October 4, 2024 07:20
@matthprost matthprost self-assigned this Oct 4, 2024
@matthprost matthprost requested review from vincentaudebert and removed request for a team October 4, 2024 07:20
Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: a610990

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.85%. Comparing base (193430a) to head (a610990).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4312   +/-   ##
=======================================
  Coverage   86.84%   86.85%           
=======================================
  Files         316      316           
  Lines       11527    11529    +2     
  Branches     3182     3141   -41     
=======================================
+ Hits        10011    10013    +2     
  Misses       1516     1516           
Files with missing lines Coverage Δ
...ckages/form/src/components/TextAreaField/index.tsx 92.30% <100.00%> (+0.64%) ⬆️
packages/ui/src/components/TextArea/index.tsx 92.59% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 193430a...a610990. Read the comment docs.

@matthprost matthprost merged commit 8300d7b into main Oct 4, 2024
11 checks passed
@matthprost matthprost deleted the fix/text-area-label branch October 4, 2024 09:12
@scaleway-bot scaleway-bot mentioned this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants