Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SelectInputV2): fix dropdown align on left #4423

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matthprost
Copy link
Collaborator

@matthprost matthprost commented Nov 5, 2024

Summary

Type

  • Bug

Summarise concisely:

What is expected?

  • Fix SelectInputV2 to align left dropdown when the dropdown is bigger than the input
  • Implement align into Popup to choose to align the popup depeding on children (only start and center available for now)

Relevant logs and/or screenshots

Page Before After
using align start on popover Screenshot 2024-11-05 at 11 28 23 Screenshot 2024-11-05 at 11 26 44
SelectInputV2 Screenshot 2024-11-05 at 11 43 39 Screenshot 2024-11-05 at 11 43 43

@matthprost matthprost added bug Something isn't working enhancement New feature or request labels Nov 5, 2024
@matthprost matthprost requested a review from a team November 5, 2024 10:50
@matthprost matthprost self-assigned this Nov 5, 2024
@matthprost matthprost requested review from fabienhebert and radhi-nasser-scaleway and removed request for a team November 5, 2024 10:50
Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: 0b0114d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@31e99b2). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/ui/src/components/Popup/helpers.ts 76.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4423   +/-   ##
=======================================
  Coverage        ?   86.86%           
=======================================
  Files           ?      322           
  Lines           ?    11773           
  Branches        ?     3228           
=======================================
  Hits            ?    10227           
  Misses          ?     1546           
  Partials        ?        0           
Files with missing lines Coverage Δ
packages/ui/src/components/MenuV2/index.tsx 100.00% <ø> (ø)
packages/ui/src/components/Popover/index.tsx 100.00% <ø> (ø)
packages/ui/src/components/Popup/index.tsx 89.00% <100.00%> (ø)
...kages/ui/src/components/SelectInputV2/Dropdown.tsx 43.77% <ø> (ø)
packages/ui/src/components/Popup/helpers.ts 82.94% <76.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31e99b2...0b0114d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants