Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(searchinput): add defaultValue prop for initial value and value for change value locally #4734

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

JulienSaguez
Copy link
Contributor

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

Add value prop for initial value

The following changes where made:

(Describe what you did)

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.97%. Comparing base (913a498) to head (0cd3408).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
packages/ui/src/components/SearchInput/index.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4734      +/-   ##
==========================================
- Coverage   88.98%   88.97%   -0.01%     
==========================================
  Files         227      227              
  Lines        7972     7976       +4     
  Branches     3666     3669       +3     
==========================================
+ Hits         7094     7097       +3     
- Misses        878      879       +1     
Files with missing lines Coverage Δ
packages/ui/src/components/SearchInput/index.tsx 94.78% <80.00%> (-0.72%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e0f88b...0cd3408. Read the comment docs.

Copy link

changeset-bot bot commented Feb 4, 2025

🦋 Changeset detected

Latest commit: 8a66a16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JulienSaguez JulienSaguez changed the title feat(searchinput): add value prop for initial value feat(searchinput): add initialValue prop for initial value and value for change value locally Feb 4, 2025
@matthprost matthprost requested a review from philibea February 4, 2025 16:18
Co-authored-by: radhi-nasser-scaleway <rnasser@scaleway.com>
@JulienSaguez JulienSaguez changed the title feat(searchinput): add initialValue prop for initial value and value for change value locally feat(searchinput): add defaultValue prop for initial value and value for change value locally Feb 5, 2025
@JulienSaguez JulienSaguez merged commit 1b5dd12 into main Feb 5, 2025
24 checks passed
@JulienSaguez JulienSaguez deleted the feat/add-prop-value-searchInput branch February 5, 2025 09:26
@scaleway-bot scaleway-bot mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants