Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(SelectableCard): add test to get by role checkbox or radio #4871

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Tests

Summarise concisely:

What is expected?

Add one more test for SelectableCard to test that it should also work when we get by role and with the correct name.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@matthprost matthprost added the ci label Mar 10, 2025
@matthprost matthprost requested a review from a team March 10, 2025 16:37
@matthprost matthprost self-assigned this Mar 10, 2025
@matthprost matthprost requested review from vincentaudebert and removed request for a team March 10, 2025 16:38
@matthprost matthprost requested a review from lisalupi as a code owner March 10, 2025 16:38
Copy link

changeset-bot bot commented Mar 10, 2025

⚠️ No Changeset found

Latest commit: 286d78f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.37%. Comparing base (4ec36ad) to head (286d78f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4871   +/-   ##
=======================================
  Coverage   89.37%   89.37%           
=======================================
  Files         234      234           
  Lines        8180     8180           
  Branches     3752     3703   -49     
=======================================
  Hits         7311     7311           
  Misses        869      869           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec36ad...286d78f. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants