Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SelectableCardOptionGroup): implement missing props and fix disabled #4885

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Bug

Summarise concisely:

What is expected?

  • Fix disabled state
  • Make the option field with a better naming
  • Fix field types especially onChange and onChangeOption being required while they shouldn't
  • Add placeholder text into the option

@matthprost matthprost added the bug Something isn't working label Mar 12, 2025
@matthprost matthprost self-assigned this Mar 12, 2025
@matthprost matthprost requested review from johnrazeur, a team and lisalupi as code owners March 12, 2025 17:09
Copy link

changeset-bot bot commented Mar 12, 2025

🦋 Changeset detected

Latest commit: c66591d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/form Patch
@ultraviolet/ui Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: Vincent <vaudebert@scaleway.com>
@matthprost matthprost enabled auto-merge (squash) March 12, 2025 17:17
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.36%. Comparing base (655ee66) to head (c66591d).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4885   +/-   ##
=======================================
  Coverage   89.36%   89.36%           
=======================================
  Files         235      235           
  Lines        8231     8231           
  Branches     3768     3720   -48     
=======================================
  Hits         7356     7356           
  Misses        875      875           
Files with missing lines Coverage Δ
...omponents/SelectableCardOptionGroupField/index.tsx 64.70% <ø> (ø)
...nts/SelectableCardOptionGroup/components/Image.tsx 100.00% <100.00%> (ø)
...ts/SelectableCardOptionGroup/components/Option.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 655ee66...c66591d. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthprost matthprost disabled auto-merge March 12, 2025 17:23
@matthprost matthprost merged commit 284ec89 into main Mar 12, 2025
15 checks passed
@matthprost matthprost deleted the fix/selectable-card-option branch March 12, 2025 17:25
@scaleway-bot scaleway-bot mentioned this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants