fix(Navigation): implement item provider to detect parents #4893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthprost
requested review from
vincentaudebert and
alexandre-combemorel
and removed request for
a team
🦋 Changeset detectedLatest commit: 59dffc5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthprost
force-pushed
the
fix/navigation
branch
from
1c68137 to
5ec61e5
Compare
matthprost
force-pushed
the
fix/navigation
branch
from
5ec61e5 to
59dffc5
Compare
vincentaudebert
approved these changes
Mar 18, 2025
alexandre-combemorel
approved these changes
Mar 18, 2025
lisalupi
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
Fix
Navigation.Itemnot to spreadhasParentprop into the children. Instead I made anItemProviderthat will act just the same. If the item detects that provider is initialised then it means it has a parent withItemProvidergiving same value ashasParent