Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SelectInputFieldV2): call on change after field value change #4894

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Bug

Summarise concisely:

What is expected?

We want to call onChange after the field changed.

@matthprost matthprost added the bug Something isn't working label Mar 14, 2025
@matthprost matthprost self-assigned this Mar 14, 2025
@matthprost matthprost requested review from johnrazeur, a team and lisalupi as code owners March 14, 2025 14:11
Copy link

changeset-bot bot commented Mar 14, 2025

🦋 Changeset detected

Latest commit: d71f431

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ultraviolet/form Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (3c5e30c) to head (d71f431).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4894      +/-   ##
==========================================
- Coverage   89.36%   84.26%   -5.11%     
==========================================
  Files         235       37     -198     
  Lines        8231      661    -7570     
  Branches     3721      214    -3507     
==========================================
- Hits         7356      557    -6799     
+ Misses        875      104     -771     
Files with missing lines Coverage Δ
...s/form/src/components/SelectInputFieldV2/index.tsx 100.00% <100.00%> (ø)

... and 198 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c5e30c...d71f431. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants