Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MenuV2): add empty state on groups #4895

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

Add prop emptyState on <MenuV2.Group /> that can be usefull when searching

Relevant logs and/or screenshots

Page Before After
url Screenshot 2025-03-14 at 16 48 49 Screenshot 2025-03-14 at 16 48 41

@matthprost matthprost added the enhancement New feature or request label Mar 14, 2025
@matthprost matthprost requested review from radhi-nasser-scaleway and a team March 14, 2025 15:53
@matthprost matthprost self-assigned this Mar 14, 2025
@matthprost matthprost requested a review from lisalupi as a code owner March 14, 2025 15:53
@matthprost matthprost requested review from fabienhebert and removed request for a team March 14, 2025 15:53
Copy link

changeset-bot bot commented Mar 14, 2025

🦋 Changeset detected

Latest commit: 4705603

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.37%. Comparing base (781be4f) to head (4705603).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4895   +/-   ##
=======================================
  Coverage   89.36%   89.37%           
=======================================
  Files         235      235           
  Lines        8231     8234    +3     
  Branches     3769     3721   -48     
=======================================
+ Hits         7356     7359    +3     
  Misses        875      875           
Files with missing lines Coverage Δ
...ages/ui/src/components/MenuV2/components/Group.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 781be4f...4705603. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabienhebert
Copy link
Collaborator

Not easier to let the developer display something else Menu.Group if he has no data for the group ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants