Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SelectableCardOptionGroup): disabled to have better visual #4905

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Fix <SelectableCardOptionGroup.Option /> disabled image to have better visual

Relevant logs and/or screenshots

Page Before After
url Screenshot 2025-03-17 at 09 40 46 Screenshot 2025-03-17 at 09 40 50

@matthprost matthprost added the bug Something isn't working label Mar 17, 2025
@matthprost matthprost self-assigned this Mar 17, 2025
@matthprost matthprost requested review from johnrazeur, a team and lisalupi as code owners March 17, 2025 08:42
@matthprost matthprost requested a review from a team March 17, 2025 08:42
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.36%. Comparing base (351d4d9) to head (7b25295).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4905   +/-   ##
=======================================
  Coverage   89.36%   89.36%           
=======================================
  Files         235      235           
  Lines        8231     8231           
  Branches     3769     3769           
=======================================
  Hits         7356     7356           
  Misses        875      875           
Files with missing lines Coverage Δ
...nts/SelectableCardOptionGroup/components/Image.tsx 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351d4d9...7b25295. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants