Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TagList): better popover #4913

Merged
merged 1 commit into from
Mar 19, 2025
Merged

fix(TagList): better popover #4913

merged 1 commit into from
Mar 19, 2025

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Bug

Summarise concisely:

What is expected?

renove arrow down on the popover for tag list as we don't want it.

@matthprost matthprost added the enhancement New feature or request label Mar 18, 2025
@matthprost matthprost requested review from vincentaudebert and a team March 18, 2025 14:17
@matthprost matthprost self-assigned this Mar 18, 2025
@matthprost matthprost requested a review from lisalupi as a code owner March 18, 2025 14:17
@matthprost matthprost requested review from Lawndlwd and removed request for a team March 18, 2025 14:17
Copy link

changeset-bot bot commented Mar 18, 2025

🦋 Changeset detected

Latest commit: 024ac16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.36%. Comparing base (ce2eb84) to head (024ac16).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4913      +/-   ##
==========================================
- Coverage   89.36%   89.36%   -0.01%     
==========================================
  Files         235      235              
  Lines        8231     8228       -3     
  Branches     3770     3719      -51     
==========================================
- Hits         7356     7353       -3     
  Misses        875      875              
Files with missing lines Coverage Δ
packages/ui/src/components/Popover/index.tsx 94.87% <100.00%> (-0.37%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c336b2...024ac16. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philibea philibea merged commit ba74625 into main Mar 19, 2025
16 checks passed
@philibea philibea deleted the fix/popup-arrow branch March 19, 2025 21:35
@scaleway-bot scaleway-bot mentioned this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants