-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(tests): describe full testing procedure #26
Conversation
Very clear, thanks! 👍 |
nice :) 👍 for me |
@scality/team-ironman-core Every single member of the team MUST read this update. |
These tests encompass the whole program, thus need a running instance of it. | ||
They can be launched with the `npm run ft_test` command, and will require the | ||
program to be started using `npm start` beforehand. They may require a few | ||
dependencies (S3 Clients, ...). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that current functional tests are run with docker: should we change that setup?
For example, Vault's functional tests start a docker instance for the server and a second one for vaultclient in order to test different routes. Would client and server be different processes in the same machine from now on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the gist of it yeah. Unless it requires a great deal of setup, in which case you would have to count it as an integration test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine, then master.yml would more or less look like:
- Test:
exec:
npm start > output &
mocha ${vaultclient_path}/${functional_test_path}/test.js
on: my_only_machine
right?
👍 |
They are meant to test heavily a single component, or test the entire | ||
project (end-to-end testing). Those may not be trivial to set up yourself, and | ||
will be only started on @ironman-machine invocation, that will start a build | ||
enabling [IronMan-Integration], meaning they belong in that repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest:
These are either meant to (a) heavily test a single component or (b) test the entire project (end-to-end testing). These tests are non-trivial to set up and will be started by an @ironman-machine invocation. These tests will be kept in the [IronMan-Integration] repository so that @ironman-machine can start a build and run the tests.
1dfacd5
to
53dbe34
Compare
Updated. |
Explicit separation of tests Explain the rationale behind the Integration project Cleanup `CONTRIBUTING.md`
docs(tests): describe full testing procedure
Explicit separation of tests
Explain the rationale behind the Integration project
Cleanup
CONTRIBUTING.md