-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use unique bucket names in scenarios where the name is not random #2177
base: development/2.6
Are you sure you want to change the base?
Conversation
Hello williamlardier,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
@@ -55,8 +55,8 @@ Feature: IAM Policies for IAM Users | |||
| GetObject | Allow | iu-go-bucket3-1/* | iu-go-bucket3 | exists | | | |||
| GetObject | Allow | iu-go-bucket4/go-object1 | iu-go-bucket4 | exists | go-object | | |||
| GetObject | Deny | * | iu-go-bucket5 | exists | | | |||
| GetObject | Deny | iu-go-bucket5/* | iu-go-bucket5 | exists | | | |||
| GetObject | Deny | iu-go-bucket6/go-object | iu-go-bucket6 | exists | go-object | | |||
| GetObject | Deny | iu-go-bucket6/* | iu-go-bucket6 | exists | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be great to be able to pass variables generated during the test in the examples, so that the given an existing bucket ...
will create an bucket named randomly and in the examples we put something like {bucketName} and it takes the one generated in the beginning
Not sure if it is feasable tho..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do that in most scenarios, but here we need to specify the resource name, and we actually want to have control over it because sometimes we alter it, so we want to keep it... Still possible to have it fully automatic but we still need to keep support for static bucket names. For example, the bucket used for website must be named "website".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we do that in most scenario, what I suggest here is to be able to use it in example, so here for example we could do ${bucketName}/*
in the ressource name
But ofc we need to keep support for creating static bucket names
/approve |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
The following options are set: approve |
Build failedThe build for commit did not succeed in branch bugfix/ZENKO-4932. The following options are set: approve |
Build failedThe build for commit did not succeed in branch w/2.9/bugfix/ZENKO-4932. The following options are set: approve |
Issue: ZENKO-4932
We had a scenario using the same (fixed) bucket name. In these kind of scenarios, this is required.
But then if they run in parallel we might have the same bucket being deleted / re-created, and eventually the hook at the end, cleaning up the existing buckets, will fail because of this concurrency problem. The solution is to use unique bucket names.