-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BB-269 avoid clearing dataStoreVersionId when retrying a replication #2350
Conversation
Hello kerkesni,My role is to assist you with the merge of this Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
b952604
to
cffbd1f
Compare
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
|
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though it may be safer (as in "future proof") to rely more on the API provided by ObjectMD to perform the update we want:
this.clone()
.setReplicationBackends(this.getReplicationBackends().filter(o => o.site === site))
.setReplicationSiteStatus(site, PENDING)
...
cffbd1f
to
7b738e8
Compare
History mismatchMerge commit #cffbd1f344a8f2a98a965bd1e01ce1d4ca3c934c on the integration branch It is likely due to a rebase of the branch Please use the |
/reset |
Reset completeI have successfully deleted this pull request's integration branches. |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
|
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue BB-269. Goodbye kerkesni. |
Issue: BB-269
Replication has special code to handle replication of tags: in that case, it will not replicate the object again, but simply update the tags on the target object.
However, in the (unlikely) case where that tag update fails, the datastore version id will be reset when the entry is put in the replay queue:
Consequently, the replay-processor would trigger a full replication of the object, and the data will be copied again.