Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: BB-309 add oplog populator metrics #2357

Merged
merged 5 commits into from
Jan 6, 2023
Merged

Feature: BB-309 add oplog populator metrics #2357

merged 5 commits into from
Jan 6, 2023

Conversation

Kerkesni
Copy link
Contributor

@Kerkesni Kerkesni commented Dec 21, 2022 •
edited by jira bot
Loading

Issue: BB-309

@Kerkesni
BB-309 fix invalid buckets not getting properly removed from the allo…
41d3022 
…cator

In the old implementation invalid buckets were removed directly from the
connectors which creates an inconsistency as we also store information about
what connector listens to what bucket in the allocator. This create a bug where
if we happen to have a bucket that becomes valid and has the same name as those
buckets in the allocator nothing would happen when trying to listen to its changes
@Kerkesni
BB-309 fix mongoClient deprecation message
3c7c712
@Kerkesni
BB-309 handle metrics route in the oplogPopulator
2fdb871
@bert-e
Copy link
Contributor

bert-e commented Dec 21, 2022

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@Kerkesni Kerkesni changed the base branch from development/8.6 to development/8.4 December 21, 2022 14:04
@scality scality deleted a comment from bert-e Dec 21, 2022
@bert-e
Copy link
Contributor

bert-e commented Dec 21, 2022

Incorrect fix version

The Fix Version/s in issue BB-309 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.4.26

  • 8.5.5

  • 8.6.2

Please check the Fix Version/s of BB-309, or the target
branch of this pull request.

@Kerkesni Kerkesni force-pushed the feature/BB-309-add-oplog-populator-metrics branch 3 times, most recently from 557accc to bfbce20 Compare December 22, 2022 15:04
@scality scality deleted a comment from bert-e Dec 22, 2022
@scality scality deleted a comment from bert-e Dec 22, 2022
@scality scality deleted a comment from bert-e Dec 22, 2022
@scality scality deleted a comment from bert-e Dec 22, 2022
@scality scality deleted a comment from bert-e Dec 22, 2022
@scality scality deleted a comment from bert-e Dec 22, 2022
@scality scality deleted a comment from bert-e Dec 22, 2022
@scality scality deleted a comment from bert-e Dec 22, 2022
@scality scality deleted a comment from bert-e Dec 22, 2022
@scality scality deleted a comment from bert-e Dec 22, 2022
@Kerkesni Kerkesni marked this pull request as ready for review December 23, 2022 10:50
@Kerkesni Kerkesni force-pushed the feature/BB-309-add-oplog-populator-metrics branch from bfbce20 to 68da51a Compare January 4, 2023 12:40
@bert-e
Copy link
Contributor

bert-e commented Jan 4, 2023 •
edited by jira bot
Loading

History mismatch

Merge commit #f84f20cbb87fb4283c8462205e80af07b876037f on the integration branch
w/8.5/feature/BB-309-add-oplog-populator-metrics is merging a branch which is neither the current
branch feature/BB-309-add-oplog-populator-metrics nor the development branch
development/8.5.

It is likely due to a rebase of the branch feature/BB-309-add-oplog-populator-metrics and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

@scality scality deleted a comment from bert-e Jan 4, 2023
@Kerkesni
Copy link
Contributor Author

Kerkesni commented Jan 4, 2023

/reset

@bert-e
Copy link
Contributor

bert-e commented Jan 4, 2023

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented Jan 4, 2023 •
edited by jira bot
Loading

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/8.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@scality scality deleted a comment from bert-e Jan 4, 2023
@bert-e
Copy link
Contributor

bert-e commented Jan 4, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@scality scality deleted a comment from bert-e Jan 4, 2023
francoisferrand
francoisferrand reviewed Jan 5, 2023
View reviewed changes
extensions/oplogPopulator/OplogPopulator.js

const paramsJoi = joi.object({
config: joi.object().required(),
mongoConfig: joi.object().required(),
activeExtensions: joi.array().required(),
logger: joi.object().required(),
enableMetrics: joi.boolean().default(true),
Copy link
Contributor

@francoisferrand francoisferrand Jan 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to make metrics optional?
i don't really see a use-case here or "precedent" in other modules, shouldn't metrics always be collected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In normal cases we always have the metrics enabled, that's why it's set to true by default.
The option was put there to be able to run unit tests with no issues, as otherwise we would get errors about the metrics being registered multiple times.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may indeed have something for the tests, but it should not propagate to the config...

@Kerkesni Kerkesni force-pushed the feature/BB-309-add-oplog-populator-metrics branch from 68da51a to 2621a81 Compare January 5, 2023 10:45
@bert-e
Copy link
Contributor

bert-e commented Jan 5, 2023

History mismatch

Merge commit #11b28243f893d90e3a603fda35d1393fefe81723 on the integration branch
w/8.5/feature/BB-309-add-oplog-populator-metrics is merging a branch which is neither the current
branch feature/BB-309-add-oplog-populator-metrics nor the development branch
development/8.5.

It is likely due to a rebase of the branch feature/BB-309-add-oplog-populator-metrics and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

@Kerkesni Kerkesni changed the base branch from development/8.4 to feature/BB-310-add-oplog-populator-dashboard January 6, 2023 16:07
@Kerkesni
Copy link
Contributor Author

Kerkesni commented Jan 6, 2023

/reset

Base automatically changed from feature/BB-310-add-oplog-populator-dashboard to development/8.4 January 6, 2023 17:00
@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2023

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/8.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@Kerkesni
Copy link
Contributor Author

Kerkesni commented Jan 6, 2023

/approve

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.4

  • ✔️ development/8.5

  • ✔️ development/8.6

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/8.3

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.4

  • ✔️ development/8.5

  • ✔️ development/8.6

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/8.3

Please check the status of the associated issue BB-309.

Goodbye kerkesni.

@bert-e bert-e merged commit 5290012 into development/8.4 Jan 6, 2023
@bert-e bert-e deleted the feature/BB-309-add-oplog-populator-metrics branch January 6, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XinLi0207 XinLi0207 XinLi0207 approved these changes

@francoisferrand francoisferrand francoisferrand approved these changes

@williamlardier williamlardier Awaiting requested review from williamlardier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kerkesni @bert-e @francoisferrand @XinLi0207