Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/BB 358/supportNewerNoncurrentVersion #2364

Merged

Conversation

alexanderchan-scality
Copy link
Contributor

  • BB-358: add support for NewerNonccurrentVersions
  • BB-358: add tests for NewerNoncurrentVersion helpers
  • bump aws-sdk to v2.1035.0

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2023

Hello alexanderchan-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2023

Incorrect fix version

The Fix Version/s in issue BB-358 contains:

  • 7.10.8

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.8

  • 8.3.20

  • 8.4.26

  • 8.5.5

  • 8.6.5

Please check the Fix Version/s of BB-358, or the target
branch of this pull request.

@alexanderchan-scality alexanderchan-scality marked this pull request as ready for review February 10, 2023 18:28
@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2023

Incorrect fix version

The Fix Version/s in issue BB-358 contains:

  • 7.10.8

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.8

  • 8.3.20

  • 8.4.26

  • 8.5.5

  • 8.6.6

Please check the Fix Version/s of BB-358, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Feb 28, 2023

Conflict

A conflict has been raised during the creation of
integration branch w/8.3/feature/BB-358/supportNewerNoncurrentVersion with contents from feature/BB-358/supportNewerNoncurrentVersion
and development/8.3.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.3/feature/BB-358/supportNewerNoncurrentVersion origin/development/8.3
 $ git merge origin/feature/BB-358/supportNewerNoncurrentVersion
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.3/feature/BB-358/supportNewerNoncurrentVersion

@alexanderchan-scality alexanderchan-scality force-pushed the feature/BB-358/supportNewerNoncurrentVersion branch from 325fbb4 to 6a265c7 Compare March 1, 2023 18:05
@alexanderchan-scality
Copy link
Contributor Author

/reset

@bert-e
Copy link
Contributor

bert-e commented Mar 1, 2023

Reset complete

I have successfully deleted this pull request's integration branches.

@alexanderchan-scality alexanderchan-scality force-pushed the feature/BB-358/supportNewerNoncurrentVersion branch from 6a265c7 to bd99d4a Compare March 1, 2023 20:51
@scality scality deleted a comment from bert-e Mar 1, 2023
@bert-e
Copy link
Contributor

bert-e commented Mar 1, 2023

Conflict

A conflict has been raised during the creation of
integration branch w/8.3/feature/BB-358/supportNewerNoncurrentVersion with contents from feature/BB-358/supportNewerNoncurrentVersion
and development/8.3.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.3/feature/BB-358/supportNewerNoncurrentVersion origin/development/8.3
 $ git merge origin/feature/BB-358/supportNewerNoncurrentVersion
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.3/feature/BB-358/supportNewerNoncurrentVersion

@bert-e
Copy link
Contributor

bert-e commented Mar 1, 2023

Conflict

A conflict has been raised during the creation of
integration branch w/8.4/feature/BB-358/supportNewerNoncurrentVersion with contents from w/8.3/feature/BB-358/supportNewerNoncurrentVersion
and development/8.4.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.4/feature/BB-358/supportNewerNoncurrentVersion origin/development/8.4
 $ git merge origin/w/8.3/feature/BB-358/supportNewerNoncurrentVersion
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.4/feature/BB-358/supportNewerNoncurrentVersion

@bert-e
Copy link
Contributor

bert-e commented Mar 1, 2023

Conflict

A conflict has been raised during the creation of
integration branch w/8.5/feature/BB-358/supportNewerNoncurrentVersion with contents from w/8.4/feature/BB-358/supportNewerNoncurrentVersion
and development/8.5.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.5/feature/BB-358/supportNewerNoncurrentVersion origin/development/8.5
 $ git merge origin/w/8.4/feature/BB-358/supportNewerNoncurrentVersion
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.5/feature/BB-358/supportNewerNoncurrentVersion

@bert-e
Copy link
Contributor

bert-e commented Mar 1, 2023

Conflict

A conflict has been raised during the creation of
integration branch w/8.6/feature/BB-358/supportNewerNoncurrentVersion with contents from w/8.5/feature/BB-358/supportNewerNoncurrentVersion
and development/8.6.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.6/feature/BB-358/supportNewerNoncurrentVersion origin/development/8.6
 $ git merge origin/w/8.5/feature/BB-358/supportNewerNoncurrentVersion
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.6/feature/BB-358/supportNewerNoncurrentVersion

@bert-e
Copy link
Contributor

bert-e commented Mar 1, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@alexanderchan-scality
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Mar 1, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/7.10

  • ✔️ development/8.3

  • ✔️ development/8.4

  • ✔️ development/8.5

  • ✔️ development/8.6

The following branches will NOT be impacted:

  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 1, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/7.10

  • ✔️ development/8.3

  • ✔️ development/8.4

  • ✔️ development/8.5

  • ✔️ development/8.6

The following branches have NOT changed:

  • development/7.4

Please check the status of the associated issue BB-358.

Goodbye alexanderchan-scality.

@bert-e bert-e merged commit bd99d4a into development/7.10 Mar 1, 2023
@bert-e bert-e deleted the feature/BB-358/supportNewerNoncurrentVersion branch March 1, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants