-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not send empty objects to tape for now #2384
Conversation
Hello rachedbenmustapha,My role is to assist you with the merge of this Status report is not available. |
eTag, | ||
|
||
archiveInfo: { | ||
archiveId: 'EMPTY_OBJECT_NO_ARCHIVE_ID', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be better to move this to lib/constants.js
const message = { | ||
op: 'archive', | ||
requestId: reqId, | ||
// omit date as it makes testing difficult |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sinon's fake timers make this a bit easier https://sinonjs.org/releases/latest/fake-timers/
d6f1626
to
8af4bea
Compare
/approve |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/8.6/feature/BB-381 origin/development/8.6
$ git merge origin/w/8.5/feature/BB-381
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/8.6/feature/BB-381 The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue BB-381. Goodbye rachedbenmustapha. |
No description provided.