Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default behaviour of selecting the first cold location on expiration of cold objects #2461

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Remove default behaviour of selecting the first cold location on expiration of cold objects #2461

merged 2 commits into from
Oct 27, 2023

Conversation

Kerkesni
Copy link
Contributor

@Kerkesni Kerkesni commented Oct 20, 2023 •
edited by francoisferrand
Loading

We don’t need this logic anymore as sorbet always sets the location name and this might introduce unwanted behaviours when having multiple locations

Issue: BB-417

@bert-e
Copy link
Contributor

bert-e commented Oct 20, 2023

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 20, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@bert-e
Copy link
Contributor

bert-e commented Oct 23, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following reviewers are expecting changes from the author, or must review again:

@Kerkesni
Remove default behaviour of selecting the first cold location on expi…
c46fe6a 
…ration of cold objects

We don’t need this logic anymore as sorbet always sets the location name
and this might introduce unwanted behaviours when having multiple locations

Issue: BB-417
@Kerkesni
add lint rule to avoid exclusive tests
9664b3e 
Issue: BB-417
@bert-e
Copy link
Contributor

bert-e commented Oct 24, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@francoisferrand francoisferrand changed the title Remove default behaviour of selecting the first cold location on expi… Remove default behaviour of selecting the first cold location on expiration of cold objects Oct 27, 2023
@Kerkesni
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Oct 27, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.7

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5
  • development/8.6

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 27, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.7

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5
  • development/8.6

Please check the status of the associated issue BB-417.

Goodbye kerkesni.

@bert-e bert-e merged commit 7b932c4 into development/8.7 Oct 27, 2023
4 checks passed
@bert-e bert-e deleted the improvement/BB-417 branch October 27, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KillianG KillianG KillianG approved these changes

@francoisferrand francoisferrand francoisferrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kerkesni @bert-e @francoisferrand @KillianG