INTEGRATION [PR#2521 > development/8.7] Timeout setup in data mover s3 client #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The S3 client didn’t have any configured timeout which made the request hang forever when a cloudserver worker crashesd thus blocking the data-mover workers. Linked issue : https://scality.atlassian.net/browse/BB-594
…tmp/octopus/w/8.7/improvement/BB-594-Data-mover-S3-clients-timeout
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 3 files with indirect coverage changes
@@ Coverage Diff @@
## development/8.7 #2523 +/- ##
===================================================
+ Coverage 68.92% 68.98% +0.05%
===================================================
Files 192 192
Lines 12683 12683
===================================================
+ Hits 8742 8749 +7
+ Misses 3931 3924 -7
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. |
bert-e
deleted the
w/8.7/improvement/BB-594-Data-mover-S3-clients-timeout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has been created automatically.
It is linked to its parent pull request #2521.
Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/8.7/improvement/BB-594-Data-mover-S3-clients-timeout, please follow thisprocedure:
$ git fetch $ git checkout w/8.7/improvement/BB-594-Data-mover-S3-clients-timeout $ # <amend or cancel the changeset by _adding_ new commits> $ git push origin w/8.7/improvement/BB-594-Data-mover-S3-clients-timeoutPlease always comment pull request #2521 instead of this one.