LifecycleDeleteObjectTask: BackbeatRoutes in S3C do not support non versioned buckets

[benzekrimaha]

Issue : BB-555

[bert-e]

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.79%. Comparing base (d19fbd5) to head (4b195cc).
Report is 1 commits behind head on development/8.7.

Files with missing lines	Patch %	Lines
lib/BackbeatMetadataProxy.js	0.00%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
...sions/lifecycle/tasks/LifecycleDeleteObjectTask.js	90.83% <100.00%> (+1.77%)	⬆️
lib/BackbeatMetadataProxy.js	50.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Components	Coverage Δ
Bucket Notification	66.66% <ø> (ø)
Core Library	74.18% <0.00%> (-0.21%)	⬇️
Ingestion	69.24% <ø> (ø)
Lifecycle	75.92% <100.00%> (+0.09%)	⬆️
Oplog Populator	82.95% <ø> (ø)
Replication	57.42% <ø> (ø)
Bucket Scanner	85.60% <ø> (ø)

@@                 Coverage Diff                 @@
##           development/8.7    #2541      +/-   ##
===================================================
- Coverage            69.86%   69.79%   -0.07%     
===================================================
  Files                  194      194              
  Lines                12897    12900       +3     
===================================================
- Hits                  9010     9004       -6     
- Misses                3877     3886       +9     
  Partials                10       10              

Flag	Coverage Δ
api:retry	9.65% <0.00%> (-0.01%)	⬇️
api:routes	9.54% <0.00%> (-0.01%)	⬇️
bucket-scanner	85.60% <ø> (ø)
ingestion	12.47% <0.00%> (-0.01%)	⬇️
lib	7.52% <0.00%> (-0.01%)	⬇️
lifecycle	19.34% <0.00%> (+0.01%)	⬆️
notification	0.88% <0.00%> (-0.01%)	⬇️
replication	18.90% <0.00%> (-0.10%)	⬇️
unit	44.88% <80.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

[williamlardier]

Let's have a ticket number with the TODO 🙂

[benzekrimaha]

Done here : https://github.com/scality/backbeat/pull/2541/files#diff-0a199af7ee10e4c59a4d84364fad46f84ce9c1cd9bffe7b55c54ed03eddb5166R53

[benzekrimaha]

/approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/8.7

The following branches have NOT changed:

• development/7.10
• development/7.4
• development/7.70
• development/8.5
• development/8.6

Please check the status of the associated issue BB-555.

Goodbye benzekrimaha.

The following options are set: approve