-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ambiguous redis connection config #2543
Conversation
Redis sentinel is what's deployed in S3C, to connect to it we use "sentinels" field in redis config that contains the host/port of each sentinel. In Artesca we use the "host" and "port" fields to connect to the redis instance. The config rules were adapted to make sure we don't pass all the fields at once which might make the config ambiguous to understand, although the redis client seems to handle this case well, as it first checks the sentinel config before connecting using the host/port fields. Default values for redis host/port were removed from the config definition and put inside the default/dev config file. Issue: BB-522
Hello kerkesni,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
@@ Coverage Diff @@
## development/8.6 #2543 +/- ##
================================================
Coverage 69.33% 69.33%
================================================
Files 194 194
Lines 12791 12791
================================================
Hits 8869 8869
Misses 3912 3912
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. |
/approve |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue BB-522. Goodbye kerkesni. The following options are set: approve |
Redis sentinel is what's deployed in S3C, to connect to it we use "sentinels" field in redis config that contains the host/port of each sentinel.
In Artesca we use the "host" and "port" fields to connect to the redis instance.
The config rules were adapted to make sure we don't pass all the fields at once which might make the config ambiguous to understand, although the redis client seems to handle this case well, as it first checks the sentinel config before connecting using the host/port fields.
Default values for redis host/port were removed from the config definition and put inside the default/dev config file.
Issue: BB-522