Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove GC producer from ObjectProcessor #2545

Merged

Conversation

benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Sep 25, 2024

Issue : BB-554

@bert-e
Copy link
Contributor

bert-e commented Sep 25, 2024

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Sep 25, 2024

Incorrect fix version

The Fix Version/s in issue BB-554 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.7.0

Please check the Fix Version/s of BB-554, or the target
branch of this pull request.

@benzekrimaha benzekrimaha force-pushed the improvement/BB-554-GC-on-lifecycleObjectProcessor branch from fed5b88 to 402b717 Compare September 26, 2024 16:16
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (93d499f) to head (31d9ca6).
Report is 2 commits behind head on development/8.7.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
...ecycle/objectProcessor/LifecycleObjectProcessor.js 73.07% <100.00%> (-2.79%) ⬇️
...ectProcessor/LifecycleObjectTransitionProcessor.js 50.74% <100.00%> (+19.49%) ⬆️

... and 1 file with indirect coverage changes

Components Coverage Δ
Bucket Notification 66.66% <ø> (ø)
Core Library 74.14% <ø> (+0.01%) ⬆️
Ingestion 69.24% <ø> (ø)
Lifecycle 75.83% <100.00%> (+0.35%) ⬆️
Oplog Populator 82.95% <ø> (ø)
Replication 57.42% <ø> (ø)
Bucket Scanner 85.76% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/8.7    #2545      +/-   ##
===================================================
+ Coverage            69.58%   69.67%   +0.08%     
===================================================
  Files                  194      194              
  Lines                12822    12819       -3     
===================================================
+ Hits                  8922     8931       +9     
+ Misses                3890     3878      -12     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.64% <0.00%> (+<0.01%) ⬆️
api:routes 9.53% <0.00%> (+<0.01%) ⬆️
bucket-scanner 85.76% <ø> (ø)
ingestion 12.48% <0.00%> (+<0.01%) ⬆️
lib 7.53% <0.00%> (+<0.01%) ⬆️
lifecycle 19.33% <12.50%> (-0.18%) ⬇️
notification 0.88% <0.00%> (+<0.01%) ⬆️
replication 18.92% <0.00%> (+<0.01%) ⬆️
unit 44.58% <100.00%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@benzekrimaha benzekrimaha force-pushed the improvement/BB-554-GC-on-lifecycleObjectProcessor branch 2 times, most recently from 402b717 to 40be608 Compare October 1, 2024 06:31
@benzekrimaha benzekrimaha marked this pull request as ready for review October 1, 2024 06:31
@benzekrimaha benzekrimaha force-pushed the improvement/BB-554-GC-on-lifecycleObjectProcessor branch 2 times, most recently from 8660624 to d85f1c3 Compare October 3, 2024 15:08
@benzekrimaha benzekrimaha force-pushed the improvement/BB-554-GC-on-lifecycleObjectProcessor branch 2 times, most recently from 00ac803 to 06d8ea6 Compare October 15, 2024 06:13
@benzekrimaha benzekrimaha force-pushed the improvement/BB-554-GC-on-lifecycleObjectProcessor branch from 06d8ea6 to 31d9ca6 Compare October 15, 2024 06:13
@benzekrimaha
Copy link
Contributor Author

/approve

@scality scality deleted a comment from bert-e Oct 15, 2024
@bert-e
Copy link
Contributor

bert-e commented Oct 15, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.7

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5
  • development/8.6

Please check the status of the associated issue BB-554.

Goodbye benzekrimaha.

The following options are set: approve

@bert-e bert-e merged commit 31d9ca6 into development/8.7 Oct 15, 2024
9 checks passed
@bert-e bert-e deleted the improvement/BB-554-GC-on-lifecycleObjectProcessor branch October 15, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants