-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support setting a site name for Kafka consumers #2547
Conversation
code in backbeat consumer already supports setting the client.rack consumer parameter to the site set in the config Issue: BB-521
Hello kerkesni,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 1 file with indirect coverage changes
@@ Coverage Diff @@
## development/8.6 #2547 +/- ##
================================================
Coverage 69.33% 69.34%
================================================
Files 194 194
Lines 12791 12791
================================================
+ Hits 8869 8870 +1
+ Misses 3912 3911 -1
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue BB-521. Goodbye kerkesni. |
Code in
backbeatConsumer
already supports setting theclient.rack
consumer parameter from the config. So here i just allow passing that field in the config as we do in S3CIssue: BB-521