condition start method on bucketprocessor #2551

benzekrimaha · 2024-10-09T12:42:04Z

bert-e · 2024-10-09T12:42:08Z

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2024-10-09T12:42:15Z

Incorrect fix version

The Fix Version/s in issue BB-549 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

8.7.0

Please check the Fix Version/s of BB-549, or the target
branch of this pull request.

Kerkesni · 2024-10-09T13:20:31Z

extensions/lifecycle/bucketProcessor/LifecycleBucketProcessor.js

@@ -451,19 +451,24 @@ class LifecycleBucketProcessor {
    start(done) {
        this.clientManager.initSTSConfig();
        this.clientManager.initCredentialsManager();
-        async.series([
+        const tasks = [


No need to take this out of the async.series, you can just call done() when this._mongoConfig is not configured.

done here : f910139#diff-0251eb0ff96b3559c00aac5d7e592f81df2eece3b644f9278307237dd8f6bbbcR459-R471

codecov · 2024-10-09T14:21:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.56%. Comparing base (5cbb606) to head (8dfabc7).
Report is 5 commits behind head on development/8.7.

Additional details and impacted files

Files with missing lines	Coverage Δ
...ecycle/bucketProcessor/LifecycleBucketProcessor.js	`79.48% <100.00%> (+0.26%)`	⬆️

... and 4 files with indirect coverage changes

Components	Coverage Δ
Bucket Notification	`66.66% <ø> (ø)`
Core Library	`74.31% <ø> (+0.16%)`	⬆️
Ingestion	`69.24% <ø> (+0.53%)`	⬆️
Lifecycle	`75.07% <100.00%> (+0.01%)`	⬆️
Oplog Populator	`82.95% <ø> (ø)`
Replication	`57.42% <ø> (ø)`
Bucket Scanner	`85.76% <ø> (ø)`

@@                 Coverage Diff                 @@
##           development/8.7    #2551      +/-   ##
===================================================
+ Coverage            69.44%   69.56%   +0.12%     
===================================================
  Files                  194      194              
  Lines                12792    12794       +2     
===================================================
+ Hits                  8883     8900      +17     
+ Misses                3899     3884      -15     
  Partials                10       10

Flag	Coverage Δ
api:retry	`9.66% <0.00%> (-0.01%)`	⬇️
api:routes	`9.56% <0.00%> (-0.01%)`	⬇️
bucket-scanner	`85.76% <ø> (ø)`
ingestion	`12.51% <0.00%> (+0.04%)`	⬆️
lib	`7.55% <0.00%> (-0.01%)`	⬇️
lifecycle	`19.43% <75.00%> (+<0.01%)`	⬆️
notification	`0.88% <0.00%> (-0.01%)`	⬇️
replication	`19.05% <0.00%> (+0.08%)`	⬆️
unit	`43.33% <100.00%> (+0.12%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Issue: BB-549

benzekrimaha · 2024-10-10T12:40:59Z

/approve

bert-e · 2024-10-10T12:41:10Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/8.7

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.5
development/8.6

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

francoisferrand · 2024-10-10T12:46:51Z

extensions/lifecycle/bucketProcessor/LifecycleBucketProcessor.js

-                    this._resumeServiceForLocation.bind(this),
-                    this._log);
-                this._locationStatusStream.start(done);
+                if (this._mongoConfig) {


note: eventually (once we support pause/resume on s3c), we will need to have an abstraction here, and always create some sort of "locationStatusStream" : listening to mongo (as today in zenko) or to something else (maybe zookeeper?)

but indeed we don't have this now, this will be done later.

bert-e · 2024-10-10T13:04:37Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/8.7

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70
development/8.5
development/8.6

Please check the status of the associated issue BB-549.

Goodbye benzekrimaha.

benzekrimaha requested a review from Kerkesni October 9, 2024 12:42

Kerkesni reviewed Oct 9, 2024

View reviewed changes

benzekrimaha force-pushed the improvement/BB-549-lifecycle-pause-resume branch 3 times, most recently from ff91dec to 7a5e390 Compare October 9, 2024 16:14

benzekrimaha requested a review from Kerkesni October 10, 2024 06:39

benzekrimaha added 2 commits October 10, 2024 09:48

condition start method on bucketprocessor

53976e2

Issue: BB-549

add unit test for start method on lbp

8dfabc7

Issue: BB-549

benzekrimaha force-pushed the improvement/BB-549-lifecycle-pause-resume branch from 7a5e390 to 8dfabc7 Compare October 10, 2024 07:49

benzekrimaha marked this pull request as ready for review October 10, 2024 07:49

Kerkesni approved these changes Oct 10, 2024

View reviewed changes

KillianG approved these changes Oct 10, 2024

View reviewed changes

francoisferrand reviewed Oct 10, 2024

View reviewed changes

francoisferrand approved these changes Oct 10, 2024

View reviewed changes

bert-e merged commit a1c64a4 into development/8.7 Oct 10, 2024
9 checks passed

bert-e deleted the improvement/BB-549-lifecycle-pause-resume branch October 10, 2024 13:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

condition start method on bucketprocessor #2551

condition start method on bucketprocessor #2551

benzekrimaha commented Oct 9, 2024 •

edited

Loading

bert-e commented Oct 9, 2024

bert-e commented Oct 9, 2024

Kerkesni Oct 9, 2024

benzekrimaha Oct 9, 2024

codecov bot commented Oct 9, 2024 •

edited

Loading

benzekrimaha commented Oct 10, 2024

bert-e commented Oct 10, 2024

francoisferrand Oct 10, 2024

bert-e commented Oct 10, 2024

condition start method on bucketprocessor #2551

condition start method on bucketprocessor #2551

Conversation

benzekrimaha commented Oct 9, 2024 • edited Loading

bert-e commented Oct 9, 2024

Hello benzekrimaha,

bert-e commented Oct 9, 2024

Incorrect fix version

Kerkesni Oct 9, 2024

Choose a reason for hiding this comment

benzekrimaha Oct 9, 2024

Choose a reason for hiding this comment

codecov bot commented Oct 9, 2024 • edited Loading

Codecov Report

benzekrimaha commented Oct 10, 2024

bert-e commented Oct 10, 2024

In the queue

francoisferrand Oct 10, 2024

Choose a reason for hiding this comment

bert-e commented Oct 10, 2024

benzekrimaha commented Oct 9, 2024 •

edited

Loading

codecov bot commented Oct 9, 2024 •

edited

Loading