Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly pass compressionType and requiredAcks to BackbeatProducer #2573

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

Kerkesni
Copy link
Contributor

@Kerkesni Kerkesni commented Nov 4, 2024

Issue: BB-620

@bert-e
Copy link
Contributor

bert-e commented Nov 4, 2024

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@scality scality deleted a comment from bert-e Nov 4, 2024
@bert-e
Copy link
Contributor

bert-e commented Nov 4, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.98%. Comparing base (a00872c) to head (13e845a).
Report is 7 commits behind head on development/9.0.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
extensions/gc/GarbageCollector.js 40.90% <ø> (ø)
extensions/gc/GarbageCollectorProducer.js 82.60% <ø> (ø)
extensions/lifecycle/LifecycleQueuePopulator.js 56.39% <ø> (ø)
...ecycle/bucketProcessor/LifecycleBucketProcessor.js 79.48% <ø> (ø)
...tensions/lifecycle/conductor/LifecycleConductor.js 83.48% <ø> (ø)
...ecycle/objectProcessor/LifecycleObjectProcessor.js 73.07% <ø> (ø)
...ectProcessor/LifecycleObjectTransitionProcessor.js 50.74% <ø> (ø)
extensions/mongoProcessor/MongoQueueProcessor.js 62.71% <ø> (ø)
...nsions/notification/NotificationConfigValidator.js 100.00% <ø> (ø)
...cation/destination/KafkaNotificationDestination.js 79.06% <100.00%> (+25.58%) ⬆️
... and 17 more
Components Coverage Δ
Bucket Notification 75.47% <100.00%> (+2.57%) ⬆️
Core Library 75.69% <100.00%> (-0.07%) ⬇️
Ingestion 69.24% <ø> (ø)
Lifecycle 76.16% <ø> (ø)
Oplog Populator 83.33% <ø> (ø)
Replication 57.79% <100.00%> (+0.11%) ⬆️
Bucket Scanner 85.60% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/9.0    #2573      +/-   ##
===================================================
+ Coverage            70.83%   70.98%   +0.14%     
===================================================
  Files                  197      197              
  Lines                13326    13285      -41     
===================================================
- Hits                  9440     9430      -10     
+ Misses                3876     3845      -31     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.57% <37.50%> (+0.03%) ⬆️
api:routes 9.39% <37.50%> (+0.02%) ⬆️
bucket-scanner 85.60% <ø> (ø)
ingestion 12.33% <25.00%> (+0.02%) ⬆️
lib 7.37% <50.00%> (-0.15%) ⬇️
lifecycle 18.91% <50.00%> (+0.05%) ⬆️
notification 1.09% <0.00%> (+<0.01%) ⬆️
replication 18.66% <62.50%> (-0.01%) ⬇️
unit 47.88% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@Kerkesni Kerkesni force-pushed the bugfix/BB-620 branch 2 times, most recently from 4ed0d0d to 2291d1b Compare November 5, 2024 11:16
lib/config.joi.js Outdated Show resolved Hide resolved
Copy link
Contributor

@benzekrimaha benzekrimaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francoisferrand francoisferrand changed the base branch from development/8.7 to development/9.0 November 20, 2024 10:39
@bert-e
Copy link
Contributor

bert-e commented Nov 20, 2024

Incorrect fix version

The Fix Version/s in issue BB-620 contains:

  • 8.7.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.0.0

Please check the Fix Version/s of BB-620, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Nov 20, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@Kerkesni Kerkesni changed the base branch from development/9.0 to improvement/BB-497 November 20, 2024 23:01
Base automatically changed from improvement/BB-497 to development/9.0 November 21, 2024 00:01
@bert-e
Copy link
Contributor

bert-e commented Nov 21, 2024

Conflict

There is a conflict between your branch bugfix/BB-620 and the
destination branch development/9.0.

Please resolve the conflict on the feature branch (bugfix/BB-620).

git fetch && \
git checkout origin/bugfix/BB-620 && \
git merge origin/development/9.0

Resolve merge conflicts and commit

git push origin HEAD:bugfix/BB-620

RING 9.4 now deploys a kafka-exporter, this should be used
to export metrics instead of manually doing it in backbeat
containers

Code is from BB-561

Issue: BB-574
Data processors are still deployed in S3C when no replication
endpoint is configured.

Issue: BB-620
S3C does not support ingestion

Issue: BB-620
The S3 config is not needed in S3C when only
deploying bucket notifications

Issue: BB-620
@bert-e
Copy link
Contributor

bert-e commented Nov 21, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@Kerkesni
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Nov 21, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.0

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5
  • development/8.6

Please check the status of the associated issue BB-620.

Goodbye kerkesni.

The following options are set: approve

@bert-e bert-e merged commit 13e845a into development/9.0 Nov 21, 2024
9 checks passed
@bert-e bert-e deleted the bugfix/BB-620 branch November 21, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants