-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
properly pass compressionType and requiredAcks to BackbeatProducer #2573
Conversation
Hello kerkesni,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
@@ Coverage Diff @@
## development/9.0 #2573 +/- ##
===================================================
+ Coverage 70.83% 70.98% +0.14%
===================================================
Files 197 197
Lines 13326 13285 -41
===================================================
- Hits 9440 9430 -10
+ Misses 3876 3845 -31
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4ed0d0d
to
2291d1b
Compare
extensions/notification/destination/KafkaNotificationDestination.js
Outdated
Show resolved
Hide resolved
2291d1b
to
9a19a4e
Compare
9a19a4e
to
1b3c44e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1b3c44e
to
a207d8e
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
a207d8e
to
5542af9
Compare
5542af9
to
6006563
Compare
ConflictThere is a conflict between your branch Please resolve the conflict on the feature branch ( git fetch && \
git checkout origin/bugfix/BB-620 && \
git merge origin/development/9.0 Resolve merge conflicts and commit git push origin HEAD:bugfix/BB-620 |
6006563
to
4fe68fd
Compare
4fe68fd
to
13e845a
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
/approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue BB-620. Goodbye kerkesni. The following options are set: approve |
Issue: BB-620