Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make probeserver config optional for bucket notification processes in S3C #2587

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Make probeserver config optional for bucket notification processes in S3C #2587

merged 5 commits into from
Nov 6, 2024

Commits on Nov 6, 2024

  1. properly validate config 

    `validate()` doesn't seem to work at all,
replaced it with `joi.attempt()` that we
use to validate the extension configs.

Issue: BB-623
    @Kerkesni
    Kerkesni committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ab33a08 View commit details
    Browse the repository at this point in the history

  2. remove probeconfig validation from startProbeServer 

    probeserver config validation should be done when
validation the config, as it can be optional in some
cases.

Issue: BB-623
    @Kerkesni
    Kerkesni committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a8c1fb2 View commit details
    Browse the repository at this point in the history

  3. make the probeserver config optional for the bucket notification proc… 

    …esses

In S3C, bucket notification processes only contain configuration for the
notification extension. We make the probeserver config optional in this case
as it is not currently supported in federation.

Issue: BB-623
    @Kerkesni
    Kerkesni committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    d130b35 View commit details
    Browse the repository at this point in the history

  4. test backbeat config validation 

    Issue: BB-623
    @Kerkesni
    Kerkesni committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    8465a7b View commit details
    Browse the repository at this point in the history

  5. remove unsupported config param 

    healthcheckServer was removed from the config
in BB-520

Issue: BB-623
    @Kerkesni
    Kerkesni committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    bb69b62 View commit details
    Browse the repository at this point in the history